Repository navigation
Conversation
ODPI-C 6.0.0 drops support for Oracle Client libraries before 19c, so
bump the version requested from dpiContext_createWithParams to 6.0 and
note the new client requirement in the docs.
Several C structs gained members across 5.x and 6.0; mirror them so the
sizeof assertions in __init__ hold:
dpiCommonCreateParams + accessToken
dpiConnCreateParams + outNewSession
dpiPoolCreateParams + maxSessionsPerShard, accessTokenCallback,
accessTokenCallbackContext
dpiDataTypeInfo + isJson, domainSchema, domainName,
annotations, isOson and the VECTOR members;
fsPrecision is uint8_t, not int16_t
dpiStmtInfo + sqlId, sqlIdLength
dpiObjectTypeInfo + packageName, packageNameLength
Also extend the type enumerations. This matters for correctness beyond
the new values: 2030 used to be DPI_ORACLE_TYPE_MAX and is now
DPI_ORACLE_TYPE_UROWID, so a UROWID column would previously have been
misread, and codes above it failed to convert at all.
Verified against Oracle Database 23.26 with client 23.26: the upstream
test suite passes, including the Lob, Bind, Variables, Cursor and
ObjectType sets.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
=========================================
+ Coverage 4.73% 5.85% +1.12%
=========================================
Files 20 23 +3
Lines 1649 1846 +197
=========================================
+ Hits 78 108 +30
- Misses 1571 1738 +167 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-written.... I saw there were several bugs in the ODPI-C release notes that I didn't want to be bothered by, hence this PR.
I have only tested on Ubuntu 26.04 against the free Oracle database.
ODPI-C 6.0.0 drops support for Oracle Client libraries before 19c, so bump the version requested from dpiContext_createWithParams to 6.0 and note the new client requirement in the docs.
Several C structs gained members across 5.x and 6.0; mirror them so the sizeof assertions in init hold:
dpiCommonCreateParams + accessToken
dpiConnCreateParams + outNewSession
dpiPoolCreateParams + maxSessionsPerShard, accessTokenCallback,
accessTokenCallbackContext
dpiDataTypeInfo + isJson, domainSchema, domainName,
annotations, isOson and the VECTOR members;
fsPrecision is uint8_t, not int16_t
dpiStmtInfo + sqlId, sqlIdLength
dpiObjectTypeInfo + packageName, packageNameLength
Also extend the type enumerations. This matters for correctness beyond the new values: 2030 used to be DPI_ORACLE_TYPE_MAX and is now DPI_ORACLE_TYPE_UROWID, so a UROWID column would previously have been misread, and codes above it failed to convert at all.
Verified against Oracle Database 23.26 with client 23.26: the upstream test suite passes, including the Lob, Bind, Variables, Cursor and ObjectType sets.