Repository navigation
Expose chat service for local accounts - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
chat.service_nameonIMsgCore.LocalAccountwhile keepingchat.account_idopaque.Group local-account rows by login, account ID, and service so callers can distinguish iMessage and SMS routes without parsing undocumented account identifiers. The new initializer argument defaults to an empty string to preserve existing source compatibility.
Verification
LocalAccounthad noservicemember.swift test --filter localAccountsPreservesOpaqueAccountIDAndReportsChatService: passed.make lint: passed with 16 pre-existing warnings and no serious violations.make test: passed 690 tests.make build: passed and produced universalimsgand bridge-helper binaries.account --localread: returned two accounts; output was reduced to the count to avoid exposing private identifiers.