Repository navigation
fix(cli): stale .env can no longer wedge stacklet stop - #95
Merged
Merged
Conversation
A stale .env missing a merged-in variable (MEDIA_ARCHIVE_DIR) made compose reject every command; down now refreshes env like up, and surfaces the compose error instead of 'unknown error'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./stack down memory(and restart, which calls down) failed with "unknown error" and could not stop the container.Root cause: the media-archive merge added
${MEDIA_ARCHIVE_DIR}:/vault/media:roto the memory compose file, but the deployed .env predated it, so the variable was blank and compose rejected the whole file (invalid spec: :/vault/media:ro: empty section between colons). compose reads the file before any action, so even stop was invalid. up re-renders .env every time; down only did so when .env was missing, so a stale one wedged the stacklet.Fix:
Not specific to memory: any stacklet that gains a compose variable hits this until env is regenerated.