Repository navigation
fix(memory): show a welcome page instead of 404 on a new wiki - #84
Merged
Merged
Conversation
Opening the family wiki right after install returned 404. The install output tells you to go there, so the first thing a new famstack did was hand you a broken link, and it stayed broken until the next night. The seeded home page was being deleted on every start. Cleanup treated any page containing the generated splice marker as a leftover projection artifact, but that marker only brackets a region, and the welcome page deliberately reserves an empty one for the wiki to fill in. Cleanup now keys off `generated: true` frontmatter, which is what marks a whole page as generated and what the generator writes on every page it publishes. The reserved region also explained how to fill it in inside an HTML comment, where nobody could read it. It now says so on the page, with the command to run if you would rather not wait for the nightly refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the family wiki right after install returned 404, and stayed that way until the first nightly sweep. The install output points you there, so a new famstack handed you a broken link.
The seeded home page was deleted on every start: cleanup treated any page containing the generated splice marker as a leftover projection artifact, but that marker only brackets a region and the welcome page deliberately reserves an empty one. Cleanup now keys off
generated: truefrontmatter, the whole-page declaration the generator writes on every page it publishes.The reserved region also explained how to fill it in inside an HTML comment, where it rendered as nothing. It now says so on the page.
Note for review: two existing purge tests asserted a page without
generated: truegets deleted, so their fixtures changed. The fixtures did not match what_publishactually writes.