Repository navigation
fix(memory): stop the curator calling a working mirror broken - #83
Merged
Merged
Conversation
The curator logged "brain git diff failed" every cycle that actually had something to mirror. Nothing was wrong: `git diff --cached --quiet` exits 1 to say staged changes exist, which is the reason to commit, but the brain helper treated every non-zero exit as a fault. So the log announced a broken mirror at precisely the moments it was doing its job, and went quiet when there was genuinely nothing to do. Anyone debugging the memory wiki read it backwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curator logged
brain git diff failedevery cycle that had something to mirror.git diff --cached --quietexits 1 to say staged changes exist, which is the reason to commit, but the brain helper treated every non-zero exit as a fault. The log therefore reported a broken mirror at exactly the moments it was working, and went quiet when there was genuinely nothing to do.