Repository navigation
fix(archivist): post the diary count only in the first introduction - #179
Merged
Merged
Conversation
The archivist posted "89 new memories in the family diary" in the memories room every morning, although nothing new had been added. On its first run the daily job counts the room's backlog instead of giving each old card a notice. Whether a card is announced is read from its thread, so the counted cards stayed unannounced and were counted again every day. The count is now only part of the first notice, which also says how to correct a card. After that, each new card in its thread is the announcement, and the room gets no daily summary. The daily-only message keys are removed and the introduction keys are renamed to `diary_intro`.
When the newest memory in the diary is two weeks old, the archivist's daily job posts one quiet notice in the memories room that invites the next one. It posts it once per quiet stretch: the next memory starts a new stretch. An empty diary gets no reminder, and a first introduction over a quiet room counts as the reminder for that stretch. The notice is `m.notice`, like the archivist's other diary messages, so no phone is woken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits that each stand alone: rebase merge.