Repository navigation
fix(stack): show image downloads when a stacklet starts - #169
Merged
Merged
Conversation
`./stack up` pulled images with visible progress only on a stacklet's first start. A release that moves a service to a new image tag left that image missing, and `compose up` downloaded it with its output captured: after `./stack update`, `./stack restart` sat at "Starting containers" for minutes with nothing on screen. Every `./stack up` now pulls the images that are missing, with compose's progress on screen. Present images are not checked against the registry, so a restart with nothing to fetch costs nothing and works offline.
`./stack restart all` failed to start photos with `on_start_ready.py error: sync() takes 4 positional arguments but 5 were given`. Hooks import their stacklet's helpers by bare name, and code and photos both ship an `oauth.py`. One process runs every stacklet's hooks, Python caches a module by name, and photos was handed the code stacklet's. The hook runner and the CLI plugin loader now forget the modules a stacklet loaded from its own directory, and restore `sys.path`, once the hook or command returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./stack upand./stack restartshow image downloads: after./stack updatemoves services to new image tags, the restart no longer sits silently at "Starting containers" while compose downloads them../stack restart allstarts photos again: hooks of code and photos each import their ownoauth.pyinstead of whichever one was loaded first.