Repository navigation
feat(archivist): answer when addressed by name - #162
Merged
Merged
Conversation
arthware-dev
force-pushed
the
fix/archivist-ask-by-mention
branch
from
September 26, 2026 18:16
21ef4e2 to
d4bf86e
Compare
arthware-dev
force-pushed
the
fix/archivist-ask-by-mention
branch
from
September 26, 2026 18:25
bf23cf6 to
816c8cf
Compare
People in a family room write "Archivist, when does the insurance
renew?" rather than picking the bot from a list. Only a picked mention
counted, so that question went unanswered.
A message on the main timeline that addresses a bot by its name, at the
start ("Archivist, ...", "hey archivist ...") or at the end
("..., Archivist?"), now counts as a mention, and the address is dropped
from the question. A name in the middle of a sentence does not count.
In a thread or a reply only a picked mention counts, so a message there
keeps its meaning: for the archivist, a correction of the filing.
The rule is the one the agent already used. It moves to
`lib/stack/name_trigger.py`; the agent container mounts that one file,
so both agree on what counts as being addressed.
The archivist's welcome in topic, personal and capture rooms told the family to start a message with `?` to search. Nothing ever handled that prefix, so such a question got no answer at all, not even "nothing found". The welcome texts (English and German) and the user guide now say to start with the archivist's name, which searches and answers, limited to the topic's folder in a topic room. Closes: #151
The archivist decides what to do with a message through a dozen gates and a command ladder spread over `_on_text`, `_on_file`, `_on_reaction` and `MicroBot`. The rules existed only in the code. The design note on who answers now has the tree for a text message, a file and a reaction, first match wins, read from the code: the Memories room, handoffs, room modes, thread ownership, corrections, and what counts as addressing the archivist.
arthware-dev
force-pushed
the
fix/archivist-ask-by-mention
branch
from
September 26, 2026 18:28
816c8cf to
b4a02f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/stack/name_trigger.pyand shared: the bot-runner imports it, the agent container mounts that one file.?prefix, which was never routed.Checked on the test Mac: a plain "Archivist, what should we bring to the picnic?" in a topic room is answered from that topic only; "I asked the archivist yesterday ..." gets no reply; a named message in the Memories room gets none either.
docs/design/brain/who-answers.mdmaps when the archivist answers as a decision tree (text, file, reaction), read from the code.Rebase merge: three commits, each its own changelog line.
Closes: #151