Repository navigation
fix(messages): make the family admin an admin in every family room - #158
Merged
Merged
Conversation
arthware-dev
force-pushed
the
fix/family-room-membership
branch
4 times, most recently
from
September 26, 2026 13:28
0917709 to
ad69bd9
Compare
The family admin from `users.toml` had admin rights only in the rooms the installer created, and only in the run that created the account. The Documents room and every room made later with `stack messages room create` had the tech admin as their only admin, so the family admin could not change settings, invite or moderate there. Every admin-role user now gets power level 100 in the family Space and every room in it: when `stack messages setup` runs, when a room is created with `stack messages room create`, when the bot-runner creates a bot room, and on every `stack up messages` through `stack messages setup --room-admins`. The last one corrects an existing install on its next restart of the messages stacklet. Closes: #157
The tech admin `stackadmin` creates every room the stack makes and stays joined, because Synapse's admin join only works in rooms it is a member of. The archivist counted it as a person. A room with one family member, the archivist and the tech admin, such as any room made with `stack messages room create`, therefore looked shared: a pasted paragraph was ignored instead of filed as that person's note, and personal filings could land in the family bucket. The framework's one definition of the stack's own accounts now covers the tech admin as well as the `-bot` accounts, so every count of the humans in a room leaves it out. Closes: #150
arthware-dev
force-pushed
the
fix/family-room-membership
branch
from
September 26, 2026 13:28
ad69bd9 to
8ae898f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stack messages setup,stack messages room createand the bot-runner, and on everystack up messagesthroughstack messages setup --room-admins, which also corrects existing installs (The family admin has no admin rights in rooms created after install #157).403 "@stackadmin:simpson not in room"once it has left, even with the family admin at power level 100.Rebase merge: each commit is its own changelog line and closes its issue. After
stack update,stack restartapplies both (core and messages change).Not in here:
?-prefix search the archivist's welcome texts promise has no routing at all, so it is independent of the tech admin.