Repository navigation
fix(memory): clone the brain projection on a fresh install - #156
Merged
Merged
Conversation
On a first `./stack up memory` the brain projection was never cloned. `on_start` creates the wiki's media mountpoint inside `~/famstack-data/memory/brain` before the containers start, and the `family/brain` repo only exists once they are up, so `git clone` met a non-empty directory and refused. The step still printed a success mark, and the curator waited for the projection forever: no wiki page was regenerated and no diary was compiled. The brain clone now turns an existing directory into a working copy in place: tracked files take the repository's version, untracked ones such as the mountpoint stay. Brain is a projection that can be rebuilt, so that is safe there; the vault keeps the strict clone. A failed vault or brain clone is now reported as a warning. Fixes: 03e1708 ("feat(memory): keep the original file behind a wiki page (#92)") Closes: #148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./stack up memorynow clones the brain projection. The wiki's media mountpoint madebrain/non-empty before the clone, sogit clonerefused, the curator waited forever and no wiki page or diary was ever written. Recreating memory hit the same path.Closes: #148