Repository navigation
feat(archivist): link the wiki page in the capture reply - #122
Merged
Merged
Conversation
The footer carried the source: the URL that was pasted, or a placeholder for typed text. That is the message directly above the reply in the room, so it repeated what the sender already had, while the only new fact -- where the capture was filed -- was not in the reply at all. It now carries a /go/capture/<id> link to the page. The resolver and the route already existed; nothing used them from here. Addressed by capture id rather than vault path because the path moves on its own: a capture re-scopes when a second person joins the room, a topic gets renamed, a correction rewrites the title. Falls back to the source footer when there is no page to point at: a capture that never reached the mirror, or an instance where core has not rendered LINK_BASE_URL yet. Nothing is lost by the swap. The page carries the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/go/capture/<id>link to the wiki page the capture was filed to.