Repository navigation
fix(memory): decide on a smaller image copy before it is placed - #121
Merged
Merged
Conversation
An image copy that is not smaller than its original was renamed into the media archive and deleted again a moment later. The wiki watches the archive, and a file that appears and disappears between two rebuilds can reach Quartz as a deletion of a file it never copied, which fails the rebuild the same way an archive temporary file did. The size is now compared while the copy still has its temporary name, so a rejected copy never appears under its final name. What is kept is unchanged. Fixes: 03e1708 ("feat(memory): keep the original file behind a wiki page (#92)")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary