Repository navigation
fix(stack): name instances installed before the installer wrote a name - #118
Merged
Merged
Conversation
The installer only started writing `[core] name` on 2026-09-22. An instance installed earlier has none, so it calls itself "stack" and searches `~/stack-extensions` for extension stacklets, while the docs and every fresh install use `~/famstack-extensions`. An extension put where the docs say is not found. The data dir has always been written as `~/<name>-data`. When `[core] name` is missing and that dir exists, the next `stack` command writes the name into `[core]` and says so. Nothing is written for an instance with a name, without a data dir, or with a data dir not named `<name>-data`. Fixes: d281407 ("feat(stack): load stacklets from extension directories")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer only started writing
[core] nameon 2026-09-22. An instance installed earlier has none, so it calls itself "stack" and searches~/stack-extensionsfor extension stacklets, while the docs and every fresh install use~/famstack-extensions. An extension put where the docs say is not found.The data dir has always been written as
~/<name>-data. When[core] nameis missing and that dir exists, the nextstackcommand writes the name into[core]and says so. Nothing is written for an instance with a name, without a data dir, or with a data dir not named<name>-data.Fixes: d281407 ("feat(stack): load stacklets from extension directories")