chore: py312 compat; imp is gone, use importlib - #24
Conversation
The long-deprecated `imp` module is gone in Python 3.12. Use the `importlib` module to provide the same functionality.
|
If you wish I could add py311/py312 and remove py35 from/to your GH actions here as well or perhaps that should be a separate PR? |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 67 67
Branches 13 10 -3
=========================================
Hits 67 67 |
if you could it would be great! |
|
I've updated the CI to add |
|
I was wrong, it does apply them immediately here :) |
it's possible to add also 3.12 by setting the python version to |
vytas7
left a comment
There was a problem hiding this comment.
LGTM, thanks for this PR!
I've just taken the liberty of bumping up python_requires (this is actually much more important nowadays than Trove classifiers).
The long-deprecated
impmodule is gone in Python 3.12. Use theimportlibmodule to provide the same functionality.Fedora is switching to Python 3.12 in rawhide (the upcoming Fedora 39 release). The
impmodule has been deprecated since Python 3.4 and is removed in 3.12.This PR changes the
impusage to instead useimportlib.