Repository navigation
Lock the edit while a video saves - #58
Merged
Merged
Conversation
When an export replaces the opened video the editor opens it again, so an edit made while it ran was thrown away. Every export that saves now locks the edit until it is done: the tools are greyed out, crop mode is left, undo and redo are off, and the timeline's edges and blocks can't be dragged. Playback and selecting still work. It locks on every saving export rather than only on Save, because Export a copy can land on the opened video too, picked in the file dialog or through a link to it, and that is only known once the export is in place. Copy never replaces the opened video, so editing carries on through it. The lock sits in the edit itself, so every way of changing it is refused, not only the ones the UI greys out. Closes #54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
/video-edit/lockedchecks that every edit operation, undo and redo are refused while locked, and that the state is unchanged. It also checks that edits work again after unlocking.