Skip to content

Ask where a video's exported copy goes - #53

Merged
faetalize merged 5 commits into
masterfrom
fix/49-video-export-inconsistency
Oct 31, 2026
Merged

faetalize merged 5 commits into
masterfrom
fix/49-video-export-inconsistency

Conversation

@faetalize

Copy link
Copy Markdown
Owner

Export as Copy now opens a file dialog after a profile is picked, like an image's Save a copy. The suggested name already has the profile's extension, and the dialog opens beside the original video, or in the Videos folder for a piped one.

Choosing the original video in the dialog replaces it.

Copy to the clipboard still skips the dialog.

Part of #49.

faetalize and others added 3 commits October 30, 2026 05:21
Export as Copy, and exporting a piped video, used to drop the file into
~/Videos without asking. After the profile is picked they now open a file
dialog, like an image's Save a copy, so the extension in the suggested
name is already the profile's. It starts beside the opened video, since a
copy belongs with its original, or in the videos folder for a piped one.
Picking the opened video itself counts as replacing it, so the editor
reopens the export instead of reading it as the original.

Copy to the clipboard still skips the dialog and writes into the videos
folder.
Exporting over the opened video by another path, through a symlinked
folder say, went unnoticed because the check compared paths. The editor
then read the export as the original and a later export made the same
edits twice.

The check now compares file ids once the export is in place, rather than
before it, because the rename only replaces the name picked: beforehand
a symlink or a hard link to the opened video has the same id as the video
itself, even though exporting over it leaves the video untouched.

That also makes the reopen flag redundant, since an export knows by then
whether it took the opened video's place.
It no longer takes a missing folder to mean "just the first name": a
folder that doesn't exist has that name free anyway, so the dialog can
always ask with its folder. The check for a folder without a path goes
too, since a video can only be opened with one.

Every name being taken now suggests none, rather than a taken one. The
search itself stays, so accepting the suggestion after an earlier export
doesn't land on replacing it.
GTK reports it as GTK_DIALOG_ERROR_DISMISSED, which, unlike the text of
the message, is something it promises to keep.
@faetalize
faetalize merged commit 5d7b7eb into master Oct 31, 2026
2 checks passed
@faetalize
faetalize deleted the fix/49-video-export-inconsistency branch October 31, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant