Repository navigation
Ask where a video's exported copy goes - #53
Merged
Merged
Conversation
Export as Copy, and exporting a piped video, used to drop the file into ~/Videos without asking. After the profile is picked they now open a file dialog, like an image's Save a copy, so the extension in the suggested name is already the profile's. It starts beside the opened video, since a copy belongs with its original, or in the videos folder for a piped one. Picking the opened video itself counts as replacing it, so the editor reopens the export instead of reading it as the original. Copy to the clipboard still skips the dialog and writes into the videos folder.
Exporting over the opened video by another path, through a symlinked folder say, went unnoticed because the check compared paths. The editor then read the export as the original and a later export made the same edits twice. The check now compares file ids once the export is in place, rather than before it, because the rename only replaces the name picked: beforehand a symlink or a hard link to the opened video has the same id as the video itself, even though exporting over it leaves the video untouched. That also makes the reopen flag redundant, since an export knows by then whether it took the opened video's place.
It no longer takes a missing folder to mean "just the first name": a folder that doesn't exist has that name free anyway, so the dialog can always ask with its folder. The check for a folder without a path goes too, since a video can only be opened with one. Every name being taken now suggests none, rather than a taken one. The search itself stays, so accepting the suggestion after an earlier export doesn't land on replacing it.
GTK reports it as GTK_DIALOG_ERROR_DISMISSED, which, unlike the text of the message, is something it promises to keep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export as Copy now opens a file dialog after a profile is picked, like an image's Save a copy. The suggested name already has the profile's extension, and the dialog opens beside the original video, or in the Videos folder for a piped one.
Choosing the original video in the dialog replaces it.
Copy to the clipboard still skips the dialog.
Part of #49.