Skip to content

feat(utils): safely parse front matter date in readLastUpdateData (Fixes #5691) - #12355

Open
ameerhmz wants to merge 1 commit into
facebook:mainfrom
ameerhmz:fix/last-update-frontmatter-invalid-date-fallback
Open

feat(utils): safely parse front matter date in readLastUpdateData (Fixes #5691)#12355
ameerhmz wants to merge 1 commit into
facebook:mainfrom
ameerhmz:fix/last-update-frontmatter-invalid-date-fallback

Conversation

@ameerhmz

Copy link
Copy Markdown

Description

Fixes #5691 by ensuring invalid date strings in front matter last_update.date / date are safely handled in readLastUpdateData without propagating NaN timestamps or breaking VCS fallback lookups.

Changes

  1. Safely validate parsed timestamp via Number.isNaN(parsedDate) in packages/docusaurus-utils/src/lastUpdateUtils.ts.
  2. Added unit test handles invalid date string in front matter gracefully in packages/docusaurus-utils/src/__tests__/lastUpdateUtils.test.ts.

Test Plan

  • Added unit test covering invalid front matter date strings.

@meta-cla

meta-cla Bot commented Aug 10, 2026

Copy link
Copy Markdown

Hi @ameerhmz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Aug 10, 2026

Copy link
Copy Markdown

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 6cdc15f
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6a79e833bb7ddd00087fa3ab
😎 Deploy Preview https://deploy-preview-12355--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla

meta-cla Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last updated: feeding data through front matter, new "created" metadata

1 participant