scale the camera to keep the banana in view - #2
Open
marler8997 wants to merge 1 commit into
Open
marler8997 wants to merge 1 commit into
marler8997 wants to merge 1 commit into
Conversation
marler8997
force-pushed
the
scaleCameraBananaView
branch
from
March 3, 2021 19:03
0c4b02e to
78ae900
Compare
Owner
Author
|
that gradient looks great, I like it. yeah not having the building looks a bit weird. I think I liked the look of zooming out to see the whole scene with the banana way up there and the city below, but I don't really know what the other method would look like to be fair. Generating more buildings seems like a reasonable solution if we want to go that route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Addresses issue #1