Skip to content

fix(req): ignore trailing root dot in subdomains #7331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lin-hongkuan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(req): ignore trailing root dot in subdomains #7331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,10 @@ defineGetter(req, 'subdomains', function subdomains() {

if (!hostname) return [];

// Strip the optional DNS root label so fully-qualified domain names
// produce the same subdomain list as their non-root-qualified form.
hostname = hostname.replace(/\.$/, '');

@krzysdz krzysdz Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A regular expression is going to be slower than something like:

Suggested change
hostname = hostname.replace(/\.$/, '');
if (hostname[hostname.length - 1] === '.') {
hostname = hostname.slice(0, -1);
}


var offset = this.app.get('subdomain offset');
var subdomains = !isIP(hostname)
? hostname.split('.').reverse()
Expand Down
13 changes: 13 additions & 0 deletions test/req.subdomains.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@ describe('req', function(){
.expect(200, ['ferrets', 'tobi'], done);
})

it('should ignore a trailing root dot', function(done){
var app = express();

app.use(function(req, res){
res.send(req.subdomains);
});

request(app)
.get('/')
.set('Host', 'tobi.ferrets.example.com.')
.expect(200, ['ferrets', 'tobi'], done);
})

it('should work with IPv4 address', function(done){
var app = express();

Expand Down