Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ app.listen = function listen() {

function logerror(err) {
/* istanbul ignore next */
if (this.get('env') !== 'test') console.error(err.stack || err.toString());
if (this.get('env') !== 'test') console.error(err);
}

/**
Expand Down
33 changes: 33 additions & 0 deletions test/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,36 @@ describe('without NODE_ENV', function(){
assert.strictEqual(app.get('env'), 'development')
})
})

describe('default error logging', function () {
before(function () {
this.error = console.error
this.env = process.env.NODE_ENV
process.env.NODE_ENV = 'development'
})

after(function () {
console.error = this.error
process.env.NODE_ENV = this.env
})

it('should log the error object', function (done) {
var app = express()
var error = new Error('boom', { cause: new Error('cause') })

console.error = function (value) {
assert.strictEqual(value, error)
done()
}

app.use(function (req, res, next) {
next(error)
})

request(app)
.get('/')
.expect(500, function (err) {
if (err) done(err)
})
})
})