Repository navigation
Viewer: a Flows view for compare:flows --report, each flow a filmstrip of its checkpoints - #79
Draft
brentvatne wants to merge 1 commit into
Draft
brentvatne wants to merge 1 commit into
brentvatne wants to merge 1 commit into
Conversation
…p of its checkpoints compare:flows --report DIR writes a report that opens on the Viewer's new Flows view: the after run's report with the comparison beside it (exploration.json flowReview) and both builds' checkpoint screenshots. Each checkpoint carries its verdict, changed regions, and the text its screen showed (labels and values from the run's accessibility artifacts). A flows run now records each flow's steps (actions, described steps, checkpoints) and the step it failed at, so the review can show the steps that led to a checkpoint. The Flows view lists the flows with what happened to each (Changed / All, Changed keeping every run that stopped), and shows one flow as a filmstrip of its checkpoints, opened at its first problem. Above the middle checkpoint are the steps that led to it, its name and status, and, for a change too small to read in the picture, the text that changed, or why the run stopped. Before | After (X) flips every picture in place; the arrows step the checkpoints, J and K the changed areas. Nothing is saved. The filmstrip is Screens' own, moved to components/shared/filmstrip.tsx; Screens wraps it. Flows takes P and Ctrl+4, and appears only in a report with a review.
|
Viewer preview of b48a228 · reports from brentvatne/euxy#163
The link stays the same on every push. Deploy run |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #78.
compare:flows --report DIRwrites a report that opens on a new Flows view in the Viewer. Host it withreport:upload DIR.Preview: a euxy two-build review: https://brents-expo-explore--q4b86f38r7.expo.app/p/ampb2i7u7x6y7jdhvzqiztf75cihau3s. The demo runs were made before steps were recorded, so the steps in this preview were added by hand.
What the view shows
“Output latency”, was “Latency offset”); otherwise the reason the run stopped, if it did.Changes
ExplorationFlow.steps,failedStep).review/flow-review.tsbuildsflowReview, a report field the Viewer reads (contract incontracts/flow-comparison.ts).views/flows.tsxandutils/flows-model.ts;components/shared/filmstrip.tsx, and Screens wraps it;/flowslink without one opens the Map.Tests
flows-model(filter, marks, status lines, steps before a checkpoint, text changes, the one-line text change).npm testpasses (1752 tests);tscis clean;🤖 Generated with Claude Code