Repository navigation
Workflows: the launch decoder's time limit kills a hung apt-get - #72
Merged
Merged
Conversation
timeout without -k sends one SIGTERM and then waits for the command however long it takes, and through sudo the signal reached an apt-get that did not exit on it: in brentvatne/euxy review run 40042718931 the first attempt took 7 minutes under a 2-minute limit. timeout now runs under sudo, so it signals apt-get itself, and -k 10 kills it if it is still running.
Viewer preview of 2ae81a2 · reports from brentvatne/euxy#163
The link stays the same on every push. Deploy run |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launch decoder install's time limit now actually stops a hung
apt-get.Why
#66 wrapped each
apt-getcall intimeout 120. In brentvatne/euxy review run 40042718931, one job's first attempt still took 7 minutes; it then warned, retried and installed ffmpeg in 3 s. That one stall made the job start capturing 7 minutes after the others, which led to a second, unshared iOS repack (#71).GNU
timeoutwithout-ksends one SIGTERM and then waits for the command to exit, however long that takes. The command wassudo apt-get:sudorelays the signal toapt-get, which was blocked on the mirror and didn't exit. One install in the ten jobs of that run and main's baseline stalled like this.Change
All three templates now run
sudo timeout -k 10 120 apt-get …in place oftimeout 120 sudo apt-get …:timeoutsignalsapt-getitself;-k 10kills it if it's still running 10 s later.The step's comment says why. Apps get this by rerunning
expo-explore setup --workflows.Checked in an
ubuntu:22.04container, running the step's own scriptapt-gethangs and ignores SIGTERM, limit shortened to 3 s, this changetimeout 2against a command that ignores SIGTERM: 8 s without-k, 3 s with-k 1.🤖 Generated with Claude Code