Repository navigation
Conversation
🤖 AI code reviewDecision: Ready for human review Overall PR risk: Medium. This change modifies how inline findings render in the main comment, replacing full duplicate entries with linked id rows and adding a second trim limit for inlined findings. The aggregate size cap, dismissal logic, and /undismiss thread restoration could affect scope counts, the 'No findings.' text, and /dismiss id availability when findings are trimmed. The impact is limited to repositories with inline.enabled (off by default), and a revert rolls it back directly without affecting the embedded state format. 🔎 Reviewer summaries (3)
No findings. This review is advisory — it never blocks a merge and never auto-approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With inline comments on, each finding on a diff line appears twice: once as an inline thread, and again in the main comment as a short entry with the title, location, id and the first 160 characters of the rationale. The reader sees the same finding twice (for example expo/expo#52187).
Change
💬 Inline comments on the diff (n)it shows one row per severity with each finding'sid:, linked to its thread, and a link to a reply when an author answered. The id stays visible because/dismisstakes it, and/dismissis an issue comment, not a thread reply.maxComments, a failed link, or a stubbed thread) is listed in full./dismissand/undismissread the inline threads before they re-render, so a dismissal doesn't bring the full list back. Before, they rendered without the thread links./undismissrestores a stubbed thread before the render and links it only when the restore succeeded.oneLineRationaleare removed. Its "audit trail" reason no longer holds: the author can't edit or delete the bot's inline comment, and a resolved thread stays on the PR.templates/config.jsonc, theinlineschema comment andPLAN-inline-comments.mddescribe the new rendering.Test Plan
bun test(887 pass), typecheck, lint,fmt:checkandllp:checkpass. New tests:applyDismissalthrough a fakegh: a live thread is linked by id and a stubbed one stays listed;/undismissrestores the thread before the main comment; a failed restore stays listed; a failed thread listing renders everything in full; an aggregate dismissal with scoped idsThe truncation and
applyDismissaltests fail on the commits before their fixes, and the single-comment tests fail onmain.