Repository navigation
chore: let this repo's own reviewers rate design findings by cost - #95
Merged
Merged
Conversation
#86 added the `design` rating rule to templates/shared.md and templates/agents/correctness.md, but not to this repo's own copies in .expo-agents/code-review/. Without it, High and Medium confidence are defined only by a failure path, so a `design` finding rates Low and the coordinator drops it. Found by the AI review of #87. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🤖 AI code reviewDecision: Ready for human review Overall PR risk: Low. This additive change updates internal reviewer prompts to match published templates. No runtime code or workflows change. 🔎 Reviewer summaries (3)
No findings. This review is advisory — it never blocks a merge and never auto-approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#86 added a rule for rating
designfindings totemplates/shared.mdandtemplates/agents/correctness.md, the files adopters get. This repo reviews its own PRs with its own copies in.expo-agents/code-review/, and those didn't get it.Without the rule,
HighandMediumconfidence are defined only by "the failure or exploit", andLowfindings are not reported. Adesignfinding, which has a real cost but no failure path, ratesLowand the coordinator drops it. The AI review of #87 flagged this (id:ae47861897b3).What
The same two lines as the templates:
shared.md: adesignfinding's confidence is how directly the code shows its cost, and its impact is how large that cost is.agents/correctness.md: "no concrete failure path (or, for adesignfinding, no concrete cost)".This only changes how this repo reviews itself. The published package doesn't change.
Test plan
ecr ref-checkandecr verify-configpass on this repo's setup.🤖 Generated with Claude Code