Skip to content

chore: let this repo's own reviewers rate design findings by cost - #95

Merged
brentvatne merged 1 commit into
mainfrom
@brent/dogfood-design-rubric
Oct 23, 2026
Merged

brentvatne merged 1 commit into
mainfrom
@brent/dogfood-design-rubric

Conversation

@brentvatne

Copy link
Copy Markdown
Member

Why

#86 added a rule for rating design findings to templates/shared.md and templates/agents/correctness.md, the files adopters get. This repo reviews its own PRs with its own copies in .expo-agents/code-review/, and those didn't get it.

Without the rule, High and Medium confidence are defined only by "the failure or exploit", and Low findings are not reported. A design finding, which has a real cost but no failure path, rates Low and the coordinator drops it. The AI review of #87 flagged this (id:ae47861897b3).

What

The same two lines as the templates:

  • shared.md: a design finding's confidence is how directly the code shows its cost, and its impact is how large that cost is.
  • agents/correctness.md: "no concrete failure path (or, for a design finding, no concrete cost)".

This only changes how this repo reviews itself. The published package doesn't change.

Test plan

ecr ref-check and ecr verify-config pass on this repo's setup.

🤖 Generated with Claude Code

#86 added the `design` rating rule to templates/shared.md and
templates/agents/correctness.md, but not to this repo's own copies in
.expo-agents/code-review/. Without it, High and Medium confidence are
defined only by a failure path, so a `design` finding rates Low and the
coordinator drops it. Found by the AI review of #87.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🤖 AI code review

Decision: Ready for human review

Overall PR risk: Low. This additive change updates internal reviewer prompts to match published templates. No runtime code or workflows change.

🔎 Reviewer summaries (3)
  • consistency: I checked both prompt edits against the scaffolding copies in templates/. templates/shared.md and templates/agents/correctness.md already have the same design-finding text. I found no consistency problems.
  • correctness: I reviewed the prompt-only edits that define Confidence and Impact for design findings. The edits match the wording in templates/ and agree with the severity definitions. I found no issues.
  • security: Reviewed two reviewer-prompt Markdown edits that define how design findings rate Confidence and Impact. The edits add no code, secrets, shell use, or change to the injection boundary. No security findings.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@brentvatne
brentvatne merged commit 2761d9e into main Oct 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant