Repository navigation
fix: default the /dismiss workflow to the latest engine - #93
Merged
Merged
Conversation
templates/dismiss.yml defaulted ECR_VERSION to '^0.2.3'. On 0.x a caret
range only matches its own minor, so every scaffolded /dismiss ran 0.2.3.
That engine writes back only { review, dismissed }, silently dropping
feedback, pins, scopes and inline links from the comment state, and it
would throw on any severity it doesn't know. Default to 'latest' like the
other templates, and test that every template does.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🤖 AI code reviewDecision: Ready for human review Overall PR risk: Low. The change modifies the /dismiss workflow default from
No findings. This review is advisory — it never blocks a merge and never auto-approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
templates/dismiss.ymldefaulted toECR_VERSION: ${{ vars.ECR_VERSION || '^0.2.3' }}. On 0.x,^0.2.3means>=0.2.3 <0.3.0, so every repo scaffolded byecr initwithout anECR_VERSIONvariable runs/dismisson 0.2.3, 33 releases back. The other three templates default to'latest'.What that does today:
{ review, dismissed }, so each/dismisssilently drops feedback, pins, scopes and inline links from the comment state.designandnitseverities #86'sdesignandnitland,/dismissfails outright.expo/expo isn't affected (it pins through its own script), and expo/terraform-iam pins an exact version.
What
'latest', with a comment on why/dismisshas to track the review workflows.init-scaffold.test.tsthat everytemplates/*.ymldefaultsECR_VERSIONtolatest. It fails with the old default.Existing adopters keep their copy of the workflow, so they need to update it, or set the
ECR_VERSIONvariable. Worth a line in the release notes.🤖 Generated with Claude Code