Skip to content

fix: label a run that reviewed nothing "No review" - #101

Merged
brentvatne merged 1 commit into
mainfrom
@brent/no-review-label
Nov 3, 2026
Merged

brentvatne merged 1 commit into
mainfrom
@brent/no-review-label

Conversation

@brentvatne

Copy link
Copy Markdown
Member

Why

A comment for a run that reviewed nothing shows Decision: No review — every pass failed. The flag behind it, couldNotComplete, also marks runs where no pass ran at all:

In those cases "every pass failed" is wrong. The summary under the label already says what happened.

How

  • render.ts: the label is now "No review", in the main comment and in the routed scope table.
  • schema.ts: the couldNotComplete doc now lists every case that sets it.

Test Plan

  • New test in render.test.ts for both labels.
  • bun test (924 pass), typecheck, lint, fmt:check and llp:check pass.

The label said "No review — every pass failed", but the same flag also marks
CI runs that failed or stopped before any pass ran, so the reason was often
wrong. The summary under it already says what happened.
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Ready for human review

Overall PR risk: Low. This change modifies the decision label text from "No review — every pass failed" to "No review" for runs where couldNotComplete is true. The change affects presentation only (label text in comments and tables); the underlying flag, dismiss state, and exit codes remain unchanged. A revert of one commit restores the old label.

🔎 Reviewer summaries (3)
  • consistency: Checked the "No review" label change in the single-review and aggregate renderers, and the matching schema comment and test. Both renderers use the same label. No other source still uses the old wording. No findings.
  • correctness: I reviewed the change of the "No review" decision label in the single-scope and aggregate renderers, and the schema doc comment. The label change is consistent, and the new test matches the joined output. I found no defects.
  • security: Reviewed a label-only change: a couldNotComplete run now renders "No review" instead of "No review — every pass failed". The change touches no state marker, token, or exec path. No security finding.

🔗 Review setup:

  • This PR changes code the reviewer prompts cite (src/tests, src/core/render.ts). Check that the guidance quoting it is still correct.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@brentvatne
brentvatne merged commit 4baf238 into main Nov 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant