Repository navigation
fix: label a run that reviewed nothing "No review" - #101
Merged
Merged
Conversation
The label said "No review — every pass failed", but the same flag also marks CI runs that failed or stopped before any pass ran, so the reason was often wrong. The summary under it already says what happened.
🤖 AI code reviewDecision: Ready for human review Overall PR risk: Low. This change modifies the decision label text from "No review — every pass failed" to "No review" for runs where couldNotComplete is true. The change affects presentation only (label text in comments and tables); the underlying flag, dismiss state, and exit codes remain unchanged. A revert of one commit restores the old label. 🔎 Reviewer summaries (3)
No findings. This review is advisory — it never blocks a merge and never auto-approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A comment for a run that reviewed nothing shows Decision: No review — every pass failed. The flag behind it,
couldNotComplete, also marks runs where no pass ran at all:/reviewagent name;In those cases "every pass failed" is wrong. The summary under the label already says what happened.
How
render.ts: the label is now "No review", in the main comment and in the routed scope table.schema.ts: thecouldNotCompletedoc now lists every case that sets it.Test Plan
render.test.tsfor both labels.bun test(924 pass), typecheck, lint,fmt:checkandllp:checkpass.