Repository navigation
Reload I18n after a test pins the available locales - #12026
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I18n only stores translations for the locales that are available when it loads. When
with_published_translationsruns insidewith_available_locales(:hu), its reload rebuilds the backend with English and Hungarian only.with_available_localesthen restored the locale list without reloading, so every later test in the same process saw no Japanese, Greek or other served locales. This madeDateFormatHelperTestfail withTranslation missing: ja.date.formats.longwhenever it ran aftertest/commands/exercise/cached_content/retrieve_test.rb.with_available_localesnow callsI18n.reload!after it restores the locales, so every caller leaves the full backend behind.I couldn't run the tests locally because OpenSearch was not running, so CI will need to cover them.
🤖 Generated with Claude Code