Repository navigation
Skip impact map points for metrics without a user - #12019
Merged
Merged
Conversation
Issue and pull request metrics have no user when the GitHub author has no linked Exercism account. The map read the user's handle before checking for this, so it crashed. Those points now render nothing. Fixes EXERCISM-JS-4Y Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and pull request metrics have no user when the GitHub author has no linked Exercism account, and the impact map crashed when it tried to read the user's handle for them. The map now renders nothing for user-based metrics that arrive without a user. This change also removes two unused refs whose
useRefcalls ran conditionally, and adds a jest test for anopen_issue_metricwith no user.Fixes EXERCISM-JS-4Y.
Closes #8773
🤖 Generated with Claude Code