Repository navigation
Lazy-load Ballerina highlighting behind the lookbehind check - #12018
Merged
Merged
Conversation
The Ballerina highlight.js package contains a lookbehind regex literal. Safari before 16.4 cannot parse it, so the shared highlighting chunk failed to load on those browsers. Ballerina now loads through a dynamic import after isLookbehindSupported() passes, the same way Red and Roc do. Fixes EXERCISM-JS-N0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ballerina highlight.js package contains a lookbehind regex literal. Safari before 16.4 cannot parse lookbehind, so the shared highlighting chunk failed to load on those browsers and took down every lazy component that imports
utils/highlight. This was reported from Mobile Safari 15.6 on iOS 15.8.This change loads Ballerina through a dynamic import after
isLookbehindSupported()passes, the same way Red and Roc are loaded since #8647. A production build now puts Ballerina in its own chunk. The shared highlighting chunk only contains lookbehind inside strings, which are compiled behind the guard. The highlight jest tests pass.Fixes EXERCISM-JS-N0.
Closes #10604
🤖 Generated with Claude Code