Repository navigation
Accept precompile in boot.json, add canvas handlers - #10692
Merged
Merged
Conversation
The artifacts are stored brotli-encoded at the highest quality, so no-transform stops Cloudflare re-encoding them on the way to the browser. The artifact tests now put real objects in the LocalStack test runners bucket instead of stubbing Exercism.config and the S3 client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer kernels call the boot list
precompilerather thanpreload, and their client refuses to construct withoutcreateCanvas/destroyCanvashandlers.Kernel.tsboots withprecompile ?? preload, so sysroots published for earlier kernels (immutable, e.g. jq) keep working.The canvas handlers are no-ops (
createCanvasthrows: test runs never draw). Older kernel clients ignore handlers they don't know, so this is safe for them too.test_runner_artifactforwards the S3 object'sContent-Encoding: artifacts are now stored brotli-encoded (exercism/clientside-tooling#3), and these responses areno-transform, so the header is the only way the browser learns to decode them. Objects published without one (jq's) are unaffected.Merge order
precompile.cpp/latest.json, so it merges last.