Skip to content

Sync line-up tests - #1141

Merged
colinleach merged 2 commits into
exercism:mainfrom
BNAndras:sync-line-up
Sep 2, 2026
Merged

Sync line-up tests#1141
colinleach merged 2 commits into
exercism:mainfrom
BNAndras:sync-line-up

Conversation

@BNAndras

@BNAndras BNAndras commented Sep 2, 2026

Copy link
Copy Markdown
Member

Related to #1109

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@colinleach

colinleach commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

I'm confused. Issue #1109 was dated Apr 14, but this exercise was only added to the Julia track on July 27. An update is needed, but in response to changes in canonical-data on Aug 9.

Given all the close timings, the exercise may have been generated from a stale cache of problem-specifications.

In this PR, runtests.jl appears to have been hand-edited. The comment at the top still says:

# File last updated on 2026-07-27

There is a Jinja2 template, and tests are updated with python bin/generate_tests.py line-up. I have the .venv setup up and active in VSCode (for other reasons), so I can easily do that later today.

Edit: the tests were fine, so generate_tests.py changed only the date.

@colinleach
colinleach merged commit 9b5cd19 into exercism:main Sep 2, 2026
5 checks passed
@colinleach

Copy link
Copy Markdown
Contributor

There are only 21 completions on this recently-added exercise, so re-running tests is low-cost.

@BNAndras

BNAndras commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Oops, I didn't realize there was a generator so yeah I added the new tests by hand.

As for the linked issue, it was first created April 14, but it's automatically edited on a schedule to reflect the unsynced tests at the time of the edit. So the line-up tests are showing up now, but they wouldn't have been in the original GitHub issue from April 14. I tend to close the issue on my tracks once tests are synced so the bot creates a fresh issue. That's a bit less confusing.

@BNAndras
BNAndras deleted the sync-line-up branch September 2, 2026 18:00
@colinleach

Copy link
Copy Markdown
Contributor

I didn't realize there was a generator

Recent (both Julia and R), with many thanks to @BethanyG for implementing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants