Skip to content

Update state-of-tic-tac-toe test suite #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikSchierboom merged 1 commit into from
Sep 2, 2026
Merged

Update state-of-tic-tac-toe test suite #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions exercises/practice/state-of-tic-tac-toe/.meta/Example.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ public State State
{
if (Moves.GetValueOrDefault('X', 0) - Moves.GetValueOrDefault('O', 0) > 1 ||
Moves.GetValueOrDefault('O', 0) > Moves.GetValueOrDefault('X', 0) ||
Winners.Contains('X') && Moves.GetValueOrDefault('X', 0) == Moves.GetValueOrDefault('O', 0) ||
Winners.Contains('O') && Moves.GetValueOrDefault('X', 0) > Moves.GetValueOrDefault('O', 0) ||
Winners.Distinct().Count() > 1)
return State.Invalid;

Expand Down
6 changes: 6 additions & 0 deletions exercises/practice/state-of-tic-tac-toe/.meta/tests.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,9 @@ reimplements = "b1dc8b13-46c4-47db-a96d-aa90eedc4e8d"

[4801cda2-f5b7-4c36-8317-3cdd167ac22c]
description = "Invalid boards -> Invalid board: players kept playing after a win"

[5a84757a-fc86-4328-aec9-a5759e6ed35d]
description = "Invalid boards -> Invalid board: O kept playing after X wins"

[cf25543d-583a-4656-b9ab-f82dc00a4a02]
description = "Invalid boards -> Invalid board: X kept playing after O wins"
24 changes: 24 additions & 0 deletions exercises/practice/state-of-tic-tac-toe/StateOfTicTacToeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,4 +323,28 @@ public void Invalid_boards_invalid_board_players_kept_playing_after_a_win()
var game = new TicTacToe(board);
Assert.Equal(State.Invalid, game.State);
}

[Fact(Skip = "Remove this Skip property to run this test")]
public void Invalid_boards_invalid_board_o_kept_playing_after_x_wins()
{
string[] board = [
"OO ",
"XXX",
" O "
];
var game = new TicTacToe(board);
Assert.Equal(State.Invalid, game.State);
}

[Fact(Skip = "Remove this Skip property to run this test")]
public void Invalid_boards_invalid_board_x_kept_playing_after_o_wins()
{
string[] board = [
"XX ",
"OOO",
" XX"
];
var game = new TicTacToe(board);
Assert.Equal(State.Invalid, game.State);
}
}
Loading