Skip to content

[house] Add a Jinja test template#844

Open
IsaacG wants to merge 1 commit into
exercism:mainfrom
IsaacG:pygen.house
Open

[house] Add a Jinja test template#844
IsaacG wants to merge 1 commit into
exercism:mainfrom
IsaacG:pygen.house

Conversation

@IsaacG

@IsaacG IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member

This changes the expecations for the output layout.
This brings the exercise in line with the problem spec and breaks all existing solutions.

@IsaacG IsaacG added x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels Jun 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@IsaacG

IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

+cc @exercism/bash This changes the expected output format to match the problem spec, breaking existing implementations. Thoughts on changing this exercise in that way? Any objections?

Personally, I think moving things towards the problem spec is generally good.

@kotp

kotp commented Jun 29, 2026

Copy link
Copy Markdown
Member

I am for it, and the output change is likely an easy change for the solutions that exist. We could still commit with the "[no important files changed]" if we want to have students to opt-in on the changes, without invalidating their solutions, right?

Comment thread exercises/practice/house/house.bats Outdated
Comment on lines +4 to +5
# generated on 2026-06-29T04:05:11+00:00
# local version: 2.0.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone remember why we started putting version numbers into the tests? This change is going backwards.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why we do those. I'm in favor of dropping them.

Do you have preferences on adding the test UUIDs for each test (could be done at the same time)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have a reason to include the UUIDs. Unless we want to use them to disambiguate tests with the same name in different test groups.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

This changes the expecations for the output layout.
This brings the exercise in line with the problem spec and breaks all existing solutions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation x:size/medium Medium amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants