Update uglify-js to 3.19.3 - #14
Merged
Merged
Conversation
The minifier, so unlike the other two tool updates this one is expected to change the generated bytes, and it does: 3.3.27 ff9f393782d4b3f395b409f20afed1f0e1f855f1fc1a02dbdd4b1ec449d715e0 111,220 3.19.3 a3a26210ce5e662136417e436b5e75ba36a80e68bcd0e90f34602d378faedd26 110,307 913 bytes smaller across the same 126 lines: the file's structure is unchanged and 32 lines compress differently. A different hash is the point of the upgrade rather than a regression, so it was checked rather than assumed. Every marker survives in the same count -- the translation hooks, saveAs, and each bundled plugin -- and the set of distinct translated strings is identical, which is what would change if the minifier had dropped or rewritten something reachable. No compress or mangle flags were added to imitate the old output. The new deterministic bytes are canonical from here. Two clean builds agree, and eXeLearning's browser suite passes all 25 tests against this bundle. Pinned exactly, like the other two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minifier — so unlike the
http-serverand Jake updates, this one is expected to change the generated bytes, and it does.913 bytes smaller across the same 126 lines — the file's structure is unchanged and 32 lines simply compress differently.
Why the new hash is not a regression
A different hash is the point of the upgrade, so it was checked rather than assumed:
_("Add"),_("Central Idea"),_r(,saveAs, minicolors, mousewheel, dragscrollable, tmpl, hotkeysa3a26210ce5e…)The string set is the assertion that matters: a minifier that dropped or rewrote something reachable would show up there before it showed up as a bug.
No compress or mangle flags were added to imitate the old output. The new deterministic bytes are canonical from here.
Pinned exactly, like the other two tool updates.