Update Jake to 12.10.1 - #13
Merged
Merged
Conversation
The task runner only sequences the build; the Jakefile is unchanged and the build is still the same concatenate-and-minify it has always been. This fork keeps the original architecture on purpose, so nothing is rewritten to another tool. The 44 source files the build concatenates, and their order, are identical before and after -- checked by extracting the script list from index.html on each side and diffing it. The generated bundle is byte-identical to the one Jake 8 produced (ff9f393782d4...), which is the strongest form the check can take, and two clean builds agree. Pinned exactly, like http-server, so the version the vendor contract was validated against is stated rather than implied by the lockfile alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task runner only sequences the build. The Jakefile is unchanged and the build is still the same concatenate-and-minify it has always been — this fork keeps the original architecture on purpose, so nothing is rewritten to another tool.
What was checked
The build inputs. The 44 source files the build concatenates, and their order, are identical before and after — extracted from
index.html'sJS:LIBblock on each side and diffed, rather than assumed from the bundle looking similar.The output. Byte-identical to the bundle Jake 8.0.16 produced:
That is the strongest form this check can take, and two clean builds agree.
npm ci && npm testPinned exactly, like
http-server, so the version the vendor contract was validated against is stated rather than implied by the lockfile alone.