Update http-server to 14.1.1 - #12
Merged
Merged
Conversation
Development-only: it serves src/ for `npm start` and takes no part in the build. 0.11.1 is from 2018. Pinned exactly rather than by range. The lockfile already makes npm ci deterministic, but eXeLearning vendors what this repository builds against a recorded hash, so an exact version states the intent and survives a deliberate lockfile refresh. The production bundle is unchanged, byte for byte (ff9f393782d4b3f395b409f20afed1f0e1f855f1fc1a02dbdd4b1ec449d715e0), which is what a dev-server bump should do. `npm start` serves index.html, the source scripts and the vendored libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development-only:
http-serverservessrc/fornpm startand takes no part in the build. 0.11.1 dates from 2018.Pinned exactly rather than by range. The lockfile already makes
npm cideterministic, but eXeLearning vendors what this repository builds against a recorded hash, so an exact version states the intent and survives a deliberate lockfile refresh.Verification
npm ci && npm testff9f393782d4…npm startindex.html, the source scripts andjs/vendor/A dev-server bump that changed the bundle would have been a reason to stop and look; it did not.