Repository navigation
Fix usage chart limits and comparison totals - #2690
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage charts stacked the allowance on top of usage, inflating the Limit line and allowing it to overflow the organization chart. Both routes now share independent series on a common baseline while preserving labels, colors, tooltip order, solid limit stroke, and project legend autoscaling. Adds seeded synthetic Storybook cases, component regressions, and a real-route browser regression. No API or billing-enforcement changes.
Validation: 4 component tests, type checks, formatting/ESLint, Storybook build, and local before/after comparisons passed. Hosted client, API, E2E, and Docker checks passed on a2e794f. Head 140d8c3 merges main 89607b4; only CONTRIBUTING.md changed, with application/tests unchanged. Final-head CI is running.
Verification and implementation details
npm run test:unit -- usage-chart.svelte.test.ts,npm run check,npm run lint,npm run build-storybook, andE2E_URL=<local Aspire App endpoint> npx playwright test e2e/tests/usage-charts.e2e.ts --project=chromium --workers=1 --retries=0.