Repository navigation
Conversation
|
|
|
Follow-up reviewer-feedback and thermo-nuclear audit completed at head
Verdict: code and CI are ready. The sole remaining external merge blocker is the pending Copilot contributor CLA. |
|
Final follow-up at head
Code and CI are ready. The PR remains draft/mergeable; the only active blocking status is the external Copilot contributor CLA. |
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
5eb9dfb to
4380685
Compare
Plan changes that create a Stripe subscription now share a policy that anchors billing to day 1 at midnight UTC and prorates the initial partial period. This covers new customers and existing customers without a live subscription. Existing subscriptions request prorations without explicitly resetting their anchor or adding a trial. Monthly/yearly intervals and Stripe's interval-change rules remain in effect; legacy renewal dates are not migrated.
Validation: current
main(89607b48b) is merged. This update changes onlyCONTRIBUTING.md; application and tests are identical to61f0b4473, whose full hosted API/client/E2E/Docker checks passed. Ancestry and whitespace checks pass. No local build/test was repeated for this documentation-only update. Hosted checks on97cf904e1are pending.Local plan-change integration tests remain pending exclusive access to shared Aspire/test data. Browser verification of subscription creation requires a Stripe test key; live Stripe invoice amounts and renewal behavior are unverified. GitHub still reports a pending CLA status, although current contribution guidance now uses Apache 2.0 contribution terms.
Verification and implementation details
CreateMonthAlignedSubscriptionOptions, keeping the billing policy in one place.dotnet build Exceptionless.slnx --configuration Release -m:1;dotnet test --no-build --configuration Release -- --filter-class 'Exceptionless.Tests.Billing.StripeBillingClient*';git diff origin/main...HEAD --check.