Skip to content

Add HDF5 access strategies and the HDF5 viewer widgets built on them - #481

Draft
woutdenolf wants to merge 1 commit into
doc_glossary_ewoks_taskfrom
480-review-re-usable-silx-data-viewer-only-tree-or-tree-data-viewer
Draft

woutdenolf wants to merge 1 commit into
doc_glossary_ewoks_taskfrom
480-review-re-usable-silx-data-viewer-only-tree-or-tree-data-viewer

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

PR summary

Depends on #515 (glossary term Ewoks task).

A summary of HDF5 access cases that we want to cover to be used as-is (in ewoks tasks) or from a Qt-tree widget silx view style (orange widget):

  • Do not lock HDF5 files when opening them in read-only mode.
  • Open HDF5 files that are still being written too (in read-only mode without locking).
  • Open HDF5 files that we might be writing to or we know we will be writing to in the current process (so append mode), but which could have external links to files that we want to open in read-only mode (without locking).

Especially Orange widgets are tricky: ewoks tasks open files for reading/writing and in the same process orange widgets open those files for the tree view. Both need to open the same file in the same mode, otherwise it fails. As opposed to ewoks tasks (which open and close the file), the orange widget stays alive as long as the workflow is loaded in the canvas. This on top of usual problem: opening files for reading while an external process is or will be writing to it.

Changelog and docs contain more details.

AI Disclosure

  • No AI used
  • AI tool Claude used for to take the code from ewoksorange, ewoksfluo and silx and create Qt models and widgets

@woutdenolf woutdenolf linked an issue Sep 9, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

@woutdenolf
woutdenolf force-pushed the 480-review-re-usable-silx-data-viewer-only-tree-or-tree-data-viewer branch 8 times, most recently from a4d7068 to 72bb060 Compare September 14, 2026 08:38
@woutdenolf
woutdenolf force-pushed the 480-review-re-usable-silx-data-viewer-only-tree-or-tree-data-viewer branch 3 times, most recently from dbde802 to db48b51 Compare September 17, 2026 09:07
@woutdenolf
woutdenolf force-pushed the 480-review-re-usable-silx-data-viewer-only-tree-or-tree-data-viewer branch 3 times, most recently from 1e7ce30 to 884a2e9 Compare October 24, 2026 13:17
@woutdenolf
woutdenolf changed the base branch from main to doc_glossary_ewoks_task October 24, 2026 13:25
@woutdenolf
woutdenolf force-pushed the 480-review-re-usable-silx-data-viewer-only-tree-or-tree-data-viewer branch from 884a2e9 to 6ee440b Compare October 24, 2026 13:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review re-usable silx data viewer: only tree or tree + data viewer

1 participant