Skip to content

Fix pixi cache-dir failure and flaky notebook output check - #350

Merged
woutdenolf merged 2 commits into
mainfrom
fix-pixi-cache-dir-and-notebook-flake
Oct 10, 2026
Merged

woutdenolf merged 2 commits into
mainfrom
fix-pixi-cache-dir-and-notebook-flake

Conversation

@woutdenolf

Copy link
Copy Markdown
Member

PR summary

  • ewoks install with the pixi manager failed on a Windows CI runner with could not determine default cache directory. Pixi resolves its cache dir from PIXI_CACHE_DIR > RATTLER_CACHE_DIR > XDG_CACHE_HOME/pixi > an OS default that needs LOCALAPPDATA/HOME to be set. PixiManager now falls back to a tempfile.gettempdir()-based PIXI_CACHE_DIR when neither override is already set, so it no longer depends on that OS resolution succeeding.
  • test_notebooks[running_workflows.ipynb] flaked on the same runner: a single print(f" {name} =", value) call can be split across more than one Jupyter stream-output record (observed on Windows), so matching the expected substring against one chunk at a time missed it. The check now matches against the concatenation of all stream outputs.

Found via a failing nightly external CI job: https://gitlab.esrf.fr/workflow/external-ci/ewoks-kit/ewoks/-/jobs/2941634

AI Disclosure

  • AI tool Claude used for investigation and implementation

🤖 Generated with Claude Code

woutdenolf and others added 2 commits October 10, 2026 12:41
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@woutdenolf
woutdenolf enabled auto-merge October 10, 2026 10:43
@woutdenolf
woutdenolf force-pushed the fix-pixi-cache-dir-and-notebook-flake branch from d67755d to f4700ab Compare October 10, 2026 10:44
@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@woutdenolf
woutdenolf merged commit ff5f445 into main Oct 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant