Repository navigation
Fix pixi cache-dir failure and flaky notebook output check - #350
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
woutdenolf
enabled auto-merge
October 10, 2026 10:43
woutdenolf
force-pushed
the
fix-pixi-cache-dir-and-notebook-flake
branch
from
October 10, 2026 10:44
d67755d to
f4700ab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
ewoks installwith thepiximanager failed on a Windows CI runner withcould not determine default cache directory. Pixi resolves its cache dir fromPIXI_CACHE_DIR>RATTLER_CACHE_DIR>XDG_CACHE_HOME/pixi> an OS default that needsLOCALAPPDATA/HOMEto be set.PixiManagernow falls back to atempfile.gettempdir()-basedPIXI_CACHE_DIRwhen neither override is already set, so it no longer depends on that OS resolution succeeding.test_notebooks[running_workflows.ipynb]flaked on the same runner: a singleprint(f" {name} =", value)call can be split across more than one Jupyter stream-output record (observed on Windows), so matching the expected substring against one chunk at a time missed it. The check now matches against the concatenation of all stream outputs.Found via a failing nightly external CI job: https://gitlab.esrf.fr/workflow/external-ci/ewoks-kit/ewoks/-/jobs/2941634
AI Disclosure
🤖 Generated with Claude Code