Repository navigation
Conversation
Macawls
commented
Oct 11, 2026
Macawls
commented
- Add table-driven tests for IsValidAlias, IsValidID, and ServerFrom in internal/utils
- Covers edge cases: empty strings, boundary lengths, invalid prefixes, ports, and trailing colons
- These exported functions previously had no test coverage
aine-etke
added a commit
that referenced
this pull request
Oct 12, 2026
Member
|
Unfortunately, we can't accept this PR - it doesn't improve anything and instead pins bugged behavior as expected one in tests. But thank you for drawing attention to that, the problem has been fixed in the last commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.