Repository navigation
Conversation
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On base
36ef9a2, a fresh checkout builds the default target but notlake build gossipsub-interop. TheClilibrary'srootsnamesCli,Interop,GossipsubInteropandGossipsubSession, while itsglobscovers only the first two, so a cold default build never emitsGossipsubInterop.oleanand the executable's rootMaincannot resolve either module. No CI job builds this executable, so it stayed green. This PR adds the two missing names toglobs.What changed
One line in
lakefile.toml. TheClilibrary'sglobsis now["Cli", "Interop.*", "GossipsubInterop", "GossipsubSession"], matching the existingroots, which is unchanged. No other files change.Test plan
36ef9a2, before the fix:lake buildsucceeds (289 jobs);lake build gossipsub-interopfails withNo directory 'GossipsubInterop' or file 'GossipsubInterop.olean' in the search path entries.lake build293 jobs;lake build gossipsub-interop358 jobs and links; executable SHA-256 starts2bfdbf78.go lean, seed 1,subnet-blob-msg, imagegate-shadow:2026-11-06): 1.0, 12 checked messages, 160.8 s wall.lake test: 27786 passed, 0 failed, 0 todo, 10 skipped, in parallel and under+RTS -N1. The first parallel run hit a transient uncaught exception; the rerun was clean.scripts/lint-imports.sh: 191 module files, 0 violations. Vendor provenance check: OK.Risk / trust footprint
Build graph only: one glob list in
lakefile.toml. No runtime, wire, dependency, or vendored-code change.Notes for reviewers
Mainis the correct root for the executable, and both modules are already roots ofCli; the mismatch is between the library's two lists, so the fix belongs inglobs. No Lean test catches this class of defect; only building the target does.lake buildstill does not build the executable. A CI step runninglake build gossipsub-interopwould catch this drift; it is left out here so the diff stays one line.LICENSE (LGPL version 3)