Skip to content

[SEAM] W6.3 req/resp: drop the three mocks after PR #46 #78

Open

Description

@leolara

[SEAM] W6.3 req/resp: drop the three mocks after PR #46

PR #46 merged at b839d38 with three own mocks carried, per the organiser ruling of 7 November. All three dependencies are merged now, so every row owes a drop:

Mock Real dependency The connections to make Window
Protocols.Mock.Core #15 W5.2 (merged, PR #64) done: PR #81 merged at 6a1f832; the req/resp seam types come from Libp2p.Core, and the mock module remains only for identify and ping (issue #55) -
Protocols.Mock.Muxer #17 W5.4 (merged, PR #49 and PR #84) delete the mock: Mux.yamux and Mux.test are real Core.Muxer values since PR #84, so the suite takes muxer from them (the suite binds it at Tests/ReqResp.lean:633); PR #81's retype was the honest intermediate state 00:18 UTC 2026-11-08 (lapsed; the deletion is owed now)
Protocols.Mock.HostStream #19 W5.6 (merged, PR #61) delete the mock, take the stream and its StreamContext from the real swarm registry 00:32 UTC 2026-11-08

Triggers: the core window ran when PR #64 merged on 7 November at 07:22 UTC; the muxer window ran when PR #49 merged at 12:18 UTC; the host window ran when PR #61 merged at 12:32 UTC.

Definition of done

Ground rules

Activity

  1. IvanAnishchuk commented on Nov 10, 2026

    @IvanAnishchuk
    Contributor

    #86 moves the host onto the merged libp2p/negotiate and deletes Negotiate.Legacy. No existing signature changes. The host adds four names:

    • Libp2p.Host.upgrade runs the upgrade, with the secured checkpoint after the handshake and before the muxer stage.
    • Libp2p.Host.negotiateStream runs multistream-select on a muxed Stream, and hands the bytes after the selection to the handler.
    • Upgraded and Admission now live in Libp2p.Host. No code outside the host named them before.

    Once #86 merges, Tests/Host.lean runs real hosts over the sim (unit 1b). A swap of this unit's host mock can build its test hosts the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions