Repository navigation
[SEAM] W5.4 mux: drop the core mock and land Mux.yamux after PR #49 #77
Description
[SEAM] W5.4 mux: drop the core mock and land Mux.yamux after PR #49
PR #49 merged at 83c48e2 with Libp2p/Mux/Mock/Core.lean carried, per the organiser ruling of 7 November. Two items ride in one swap:
| Mock | Real dependency | The connections to make | Window |
|---|---|---|---|
Libp2p/Mux/Mock/Core.lean |
#15 W5.2 (merged, PR #64) |
delete the mock modules, move the imports to Libp2p.Core, and re-point Muxer and MuxSession to the real seams |
19:22 UTC 2026-11-07 |
Mux.yamux, unit 1b of #17 |
#14 W4.3 (merged, PR #62) |
the production Muxer value over the real yamux session, with the end-to-end suite over the sim pair |
with the swap, inside issue #17 |
The trigger ran on 7 November at 07:22 UTC, when PR #64 merged. The rules give 12 hours from the merge to drop each mock, so the window closes at 19:22 UTC. Issue #17 stays open for unit 1b; the swap pull request closes both when it lands.
Definition of done
hackathon26carries noMux/Mock/module.Mux.yamuxexists, and the suite covers a full upgrade over the real yamux session.- Issue [W5.4] libp2p/mux: the Muxer values #17 closes when unit 1b lands; the ledger row for PR feat(mux): W5.4, the muxer values #49 on issue [TRACKING] Machine-Checked Devcon Week: the task tree #25 gets struck when the mock drop lands.
#print axiomsover the package theorems showspropext,Classical.choice, andQuot.soundonly.lake build --wfail,lake test,lake test -- +RTS -N1 -RTS, andscripts/lint-imports.shstay green.
Ground rules
- The mux author (PR feat(mux): W5.4, the muxer values #49) owes this work; comment
claimto take it if they do not. - Work lands as a follow-up pull request against
hackathon26from the author's fork. This issue closes when the tip is clean of the mock andMux.yamuxruns. - Prose register everywhere: CLAUDE.md, "Writing Style".
Activity
Mouzayan commentedon Nov 8, 2026
claim
Mouzayan commentedon Nov 9, 2026
PR #84 is ready for review. It removes the temporary mux Core mock, integrates the landed Libp2p.Core seam, and adds the production Mux.yamux adapter over Yamux.Session with public boundary tests. Linux CI is green. This PR closes #77 and #17; Mplex remains deferred P2 work.
leolara commentedon Nov 9, 2026
The swap and Mux.yamux landed as PR #84 and merged at 5fa9e63. The mock is gone, the adapter review checked caps, ownership, leftovers, and error mapping, and the ledger row is struck.
refactor(protocols): run req/resp over the seam types of libp2p/core
docs(protocols): state the muxer mock swap is due after etheorem#84 l…