Repository navigation
[SEAM] W5.7 identify/ping: the mock connections of #45 #55
Description
Seam connections for merged PR #45 (W5.7 identify and ping). PR #45 merged at f4e35cb with two own mocks carried, per the organiser ruling of 7 November: an approved PR with a mock of a merged dependency merges, and the swaps land through this issue. The identity and multiaddr rows of the old table are done: the identity swap landed inside #45 on 6 November, and the multiaddr swap landed with the earlier base merge.
| Own mock | Real dependency | The connections to make | Window |
|---|---|---|---|
Protocols.Mock.Core |
#15 W5.2 (merged, PR #64) |
delete the mock, import Libp2p.Core, re-type the handlers over the real StreamHandler and StreamContext; the identifyId, identifyPushId, and pingId constants re-point to the real ProtocolId |
19:22 UTC 2026-11-07 |
Protocols.Mock.Host |
#19 W5.6 (merged, PR #61) |
delete the mock, take the peerstore and the served stream from the real host seam, and serve identify and push through the swarm registry | 00:32 UTC 2026-11-08 |
Definition of done
hackathon26carries noProtocols/Mock/module.#print axiomsover the package theorems showspropext,Classical.choice, andQuot.soundonly.- The ledger rows for PR feat(protocols): W5.7, identify and ping #45 on issue [TRACKING] Machine-Checked Devcon Week: the task tree #25 get struck when the swaps land.
lake build --wfail,lake test,lake test -- +RTS -N1 -RTS, andscripts/lint-imports.shstay green.
Ground rules
- The identify/ping author (PR feat(protocols): W5.7, identify and ping #45) owes this work; comment
claimto take it if they do not. - Work lands as a follow-up pull request against
hackathon26from the author's fork. This issue closes when the tip is clean of the mocks. - Prose register everywhere: CLAUDE.md, "Writing Style".
Activity
refactor(protocols): run req/resp over the seam types of libp2p/core
IvanAnishchuk commentedon Nov 10, 2026
#86 moves the host onto the merged
libp2p/negotiateand deletesNegotiate.Legacy. No existing signature changes. The host adds four names:Libp2p.Host.upgraderuns the upgrade, with the secured checkpoint after the handshake and before the muxer stage.Libp2p.Host.negotiateStreamruns multistream-select on a muxedStream, and hands the bytes after the selection to the handler.UpgradedandAdmissionnow live inLibp2p.Host. No code outside the host named them before.Once #86 merges,
Tests/Host.leanruns real hosts over the sim (unit 1b). A swap of this unit's host mock can build its test hosts the same way.IvanAnishchuk commentedon Nov 10, 2026
#87 deletes
Protocols/Mock/Muxer.leanandProtocols/Mock/HostStream.lean, and edits the package ARCHITECTURE and PLAN oflibp2p/protocols. No public signature changes.Mock/Core.leanandMock/Host.leanstay for this issue.Tests/HostPair.lean(new in #87) builds two real hosts over the sim with Noise and yamux:hostPairanswers the client, the server, the proved server peer, and the server's failures. The identify and ping suites can run on the same pair after their swap.IvanAnishchuk commentedon Nov 10, 2026
claim. 8 hours have passed, or twelve or however much, was too long in any case and I have another PR depending on this 🤷
refactor(protocols): run identify and ping on the real core and host