Skip to content

[SEAM] W5.5 negotiate: drop the stale varint and streams mocks inside #40 #53

Closed

Description

@leolara

Seam connection for merged PR #40 (W5.5 negotiate). PR #40 merged at f678d44 with Negotiate.Mock.Core carried, per the organiser ruling of 7 November: an approved PR with a mock of a merged dependency merges, and the swap lands through this issue. The other three rows of the old table are done: the varint and streams mocks dropped inside #40, and the identity mock dropped in the swap of 6 November.

Mock Real dependency The connections to make Window
Negotiate.Mock.Core #15 W5.2 (merged, PR #64) delete the mock, import Libp2p.Core, re-type the upgrader over the real SecurityProtocol and Muxer seams, and remove the prose that says core is unmerged (Mock/Core.lean:10) 19:22 UTC 2026-11-07

Definition of done

Ground rules

  • The negotiate author (PR feat(negotiate): W5.5, multistream-select and the upgrader #40) owes this work; comment claim to take it if they do not.
  • Work lands as a follow-up pull request against hackathon26 from the author's fork. This issue closes when the tip is clean of the mock.
  • Prose register everywhere: CLAUDE.md, "Writing Style".

Activity

  1. IvanAnishchuk commented on Nov 8, 2026

    @IvanAnishchuk
    Contributor

    claim. 12 hours have passed

  2. added a commit that references this issue on Nov 9, 2026
    8f395b3
  3. leolara commented on Nov 9, 2026

    @leolara
    ContributorAuthor

    The swap landed as PR #82 and merged at 147afc4. The mock is gone, the upgrader joins the SecureConn it owns on every path, and the ledger row is struck. The carried gap: releaseLate has no deterministic test for the race window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions