[tobiabidoye]

Reverts github.com/creack/pty from v1.1.24 to v1.1.18 in pkg and tests.

The bump in #22272 (Aug 18) coincides with e2e CI failing with
"fork/exec .../etcdctl: operation not permitted" (see #22610). The
upstream bug was introduced in creack/pty v1.1.20 and only partially
mitigated in v1.1.21 (creack/pty#196). The fix (creack/pty#215) is on
main but not yet in a release.

This is a temporary pin until a fixed release is available. Open
question: should dependabot ignore creack/pty until then, so the
bump isn't reintroduced?

Fixes #22610

[kubernetes-prow]

Hi @tobiabidoye. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivanvc]

/ok-to-test

Thanks, @tobiabidoye. I don't think we should pin the dependency; otherwise, we may never get to update it. Assuming it's already on their main branch, I'd expect the next release to include the bug fix.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.96%. Comparing base (6782f52) to head (da99777).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files

see 13 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #22627   +/-   ##
=======================================
  Coverage   72.95%   72.96%           
=======================================
  Files         448      448           
  Lines       31830    31830           
=======================================
+ Hits        23223    23226    +3     
+ Misses       8604     8601    -3     
  Partials        3        3           

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6782f52...da99777. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tobiabidoye]

Thanks @ivanvc, makes sense, I won't pin. The fix (creack/pty#215) is merged on creack/pty main but not in a release yet. Would you prefer I bump to a pseudo version of creack/pty main, or leave CI as is and I'll ask upstream to cut a release?

[ivanvc]

@tobiabidoye, let's leave it as is. Eventually, Dependabot should do the dependency update once they release. Thanks!

/retest

[ivanvc]

/retest

[ivanvc]

LGTM. Thanks, @tobiabidoye.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, tobiabidoye

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ivanvc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment