connector-init: demote broken-pipe stdin writes to debug - #3358
Open
jacobmarble wants to merge 1 commit into
Open
connector-init: demote broken-pipe stdin writes to debug#3358jacobmarble wants to merge 1 commit into
jacobmarble wants to merge 1 commit into
Conversation
A failed write to the connector's stdin is expected when the connector has exited or simply isn't reading stdin, which the protocol allows. Logging it at warn placed pure downstream noise beside the causal error in a task's ops logs. Log a broken pipe at debug; any other i/o error stays a warn. Closes #3354
jacobmarble
marked this pull request as ready for review
August 13, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
flow-connector-initpipes runtime requests into the connector's stdin. When a connector dies, the next write fails with a broken pipe — there's no reader left — and we logged that atwarn. It's noise: the write failed because the connector was already gone, and it sat in the task's ops logs beside the connector's real error at the same level.Broken pipes now log at
debug. Other i/o errors keep theirwarnand original wording. A connector is allowed to not read its stdin at all, so this was never treated as an error — the function's comment already said so; now the level agrees. The sibling message was demoted the same way in a1bb93b.Closes #3354.
Workflow steps:
No user-facing change. One fewer misleading
warnwhen reading ops logs for a failed task.Documentation links affected:
None.
Notes for reviewers:
The issue asked to key on "the connector has already exited", but that isn't known at the write site — the exit future hasn't resolved, which is why we're still in the loop.
BrokenPipemeans the reader is gone either way.