crates/models: resolve capture interval from the connector tag - #3333
Open
nicolaslazo wants to merge 1 commit into
Open
crates/models: resolve capture interval from the connector tag#3333nicolaslazo wants to merge 1 commit into
nicolaslazo wants to merge 1 commit into
Conversation
`connector_tags.default_capture_interval` has existed for a long time but nothing ever applied it. `interval` becomes `Option<Duration>`, with unset meaning "resolve at build time". If the model does not provide its own `interval`, then the connector tag's takes precedence over the global fallback. Build-time resolution costs propagation latency: a changed tag default reaches an existing capture only when that capture is next built. That happens automatically within twenty days via the periodic touch publication, and sooner if anything else republishes the task.
|
馃殌 Preview deployed to https://docs.estuary.dev/pr-preview/pr-3333/ 馃搫 Changed pages: |
Member
|
What about resolving this from the Spec response, Open response, or an image label? For example we change validation semantics so that "unset" propagates down into the built spec, and then have the reactor choose the restart interval through a negotiation with the started connector. It seems circuitous to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
connector_tags.default_capture_intervalhas existed for a long time but nothing ever applied it.intervalbecomesOption<Duration>, with unset meaning "resolve at build time". If the model does not provide its owninterval, then the connector tag's takes precedence over the global fallback.Build-time resolution costs propagation latency: a changed tag default reaches an existing capture only when that capture is next built. That happens automatically within twenty days via the periodic touch publication, and sooner if anything else republishes the task.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested locally using unit tests.