Skip to content

feat: Update motorgo configuration to allow selection of which motor to use#15

Merged
finger563 merged 2 commits into
mainfrom
feat/motorgo-motor-selection
Jun 7, 2026
Merged

feat: Update motorgo configuration to allow selection of which motor to use#15
finger563 merged 2 commits into
mainfrom
feat/motorgo-motor-selection

Conversation

@finger563

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 6, 2026 21:05
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

✅Static analysis result - no issues found! ✅

@finger563 finger563 self-assigned this Jun 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MotorGo Mini example configuration so developers can select which BLDC motor channel (motor 1 vs motor 2) the example controls, avoiding initialization/configuration of the unused motor.

Changes:

  • Add a Kconfig choice to select Motor 1 or Motor 2 when targeting MotorGo Mini.
  • Update main.cpp to apply PID tuning and initialize the selected MotorGo Mini motor channel accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
main/main.cpp Adds compile-time motor selection to choose and initialize Motor 1 or Motor 2 and applies shared PID tuning to the selected config.
main/Kconfig.projbuild Introduces a Kconfig choice (EXAMPLE_BLDC_MOTOR) to select which MotorGo Mini BLDC motor is controlled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread main/main.cpp
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

ESP-IDF Size Report for 'Software Defined Haptics'

Metric Base PR Delta
FLASH 617,400 bytes (29.44%) 617,460 bytes (29.44%) 🔺 +60 bytes (0.00%)
DRAM 76,515 bytes (22.39%) 76,515 bytes (22.39%) 0 bytes (0.00%)
IRAM 16,384 bytes (100.00%) 16,384 bytes (100.00%) 0 bytes (0.00%)
RAM (DRAM+IRAM) 92,899 bytes 92,899 bytes 0 bytes (0.00%)

FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available.
DRAM/IRAM usage does not include memory used by the heap allocator at runtime.
This report was generated by esp-idf-size-delta.

@finger563 finger563 merged commit 55a4387 into main Jun 7, 2026
3 checks passed
@finger563 finger563 deleted the feat/motorgo-motor-selection branch June 7, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants