feat: Update motorgo configuration to allow selection of which motor to use#15
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
Pull request overview
This PR updates the MotorGo Mini example configuration so developers can select which BLDC motor channel (motor 1 vs motor 2) the example controls, avoiding initialization/configuration of the unused motor.
Changes:
- Add a Kconfig choice to select Motor 1 or Motor 2 when targeting MotorGo Mini.
- Update
main.cppto apply PID tuning and initialize the selected MotorGo Mini motor channel accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main/main.cpp | Adds compile-time motor selection to choose and initialize Motor 1 or Motor 2 and applies shared PID tuning to the selected config. |
| main/Kconfig.projbuild | Introduces a Kconfig choice (EXAMPLE_BLDC_MOTOR) to select which MotorGo Mini BLDC motor is controlled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ESP-IDF Size Report for 'Software Defined Haptics'
FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.